fix(python-sdk): missing functions in AsyncSandbox.git#1109
Conversation
bxxf
requested review from
ValentaTomas,
jakubno and
mishushakov
as code owners
|
bxxf
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5acd249fcd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
matthewlouisbrockman
left a comment
matthewlouisbrockman
left a comment
There was a problem hiding this comment.
Thanks for catching! Good idea on the check between sync/async; minor warning on the asyncio.iscoroutinefunction - if you can switch it to inspect instead of asyncio then we can go ahead and get this in.
|
|
||
| def test_async_methods_are_coroutines(): | ||
| for name, method in _public_methods(AsyncGit).items(): | ||
| assert asyncio.iscoroutinefunction(method), f"AsyncGit.{name} is not async" |
There was a problem hiding this comment.
Getting DeprecationWarning: 'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction() instead down to use the inspect function instead?
There was a problem hiding this comment.
Thanks for flagging this! I wasn’t available at the time, but I see you’ve already resolved it - turns out my local dev env was using an older Python binary.
matthewlouisbrockman
changed the base branch from
main
to
fix-consolidate-sync-async
matthewlouisbrockman
left a comment
matthewlouisbrockman
left a comment
There was a problem hiding this comment.
trying to figure out right way to do this without ci/cd blocking; as a fix for now merging into a branch for ci/cd, adding the extra consolidation, and PRing from there.
matthewlouisbrockman
merged commit 02d9761
into
e2b-dev:fix-consolidate-sync-async
2 participants
Directly related to #1108. Please check the issue description for more details.
tldr:
.restore()and .reset()functions are missing in theAsyncSandboxinstancealso added test to check parity of methods/signatures between sync and async git instances
other potential concerns: